Skip to content

🗑️ Deprecate Color and PaymentCardNumber#6003

Merged
Kludex merged 7 commits into
mainfrom
deprecation/color-payment
Jun 5, 2023
Merged

🗑️ Deprecate Color and PaymentCardNumber#6003
Kludex merged 7 commits into
mainfrom
deprecation/color-payment

Conversation

@Kludex

@Kludex Kludex commented Jun 5, 2023

Copy link
Copy Markdown
Member

Change Summary

  • Deprecate Color and PaymentCardNumber.
  • Delete documentation for both - It will be readded from pydantic-extra-types side.

Selected Reviewer: @lig

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 5, 2023

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3254e3c
Status: ✅  Deploy successful!
Preview URL: https://17587398.pydantic-docs2.pages.dev
Branch Preview URL: https://deprecation-color-payment.pydantic-docs2.pages.dev

View logs

@Kludex Kludex requested a review from hramezani June 5, 2023 10:59
@Kludex

Kludex commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

please review

@Kludex

Kludex commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

Actually... Sorry reviewers. I want to include pydantic-extra-types documentation here as well. 🤔

Wait a bit.

@Kludex Kludex marked this pull request as draft June 5, 2023 11:05
@Kludex Kludex marked this pull request as ready for review June 5, 2023 12:14
@Kludex

Kludex commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

please review

Comment thread pydantic/types.py Outdated

@yezz123 yezz123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Kludex and others added 2 commits June 5, 2023 14:22
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@Kludex Kludex enabled auto-merge (squash) June 5, 2023 12:27
@Kludex Kludex merged commit 3c4fee5 into main Jun 5, 2023
@Kludex Kludex deleted the deprecation/color-payment branch June 5, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants