Switching to pydantic_core#4516
Merged
Merged
Conversation
5 tasks
This was referenced Oct 27, 2022
Closed
tiangolo
approved these changes
Nov 1, 2022
tiangolo
left a comment
Contributor
There was a problem hiding this comment.
AMAZING! 🚀 🎉
I love the new structure for users. I read all the code in this PR. Not sure how much I understood but I read it all. 😅
It all looks great! I just added some minor comments.
hramezani
reviewed
Nov 2, 2022
hramezani
reviewed
Nov 2, 2022
Suggestions from @tiangolo and @hramezani 🙏 Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Member
Author
|
💥 🚀 |
|
That's incredible progress. |
13 tasks
pawelrubin
reviewed
Nov 3, 2022
2 tasks
5 tasks
11 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the big one 😱.
I'd love @PrettyWood @hramezani @tiangolo @adriangb and others to review this. Having to fix some suggestions, but given how big this is, I might defer some suggestions to subsequent PRs.
I'm sorry there's so much noise - obviously it would be great if the interesting bits could be in a different PR to the refactoring, but that wasn't possible while keeping tests "passing".
Test situation now:
There's a lot still to do, but the core functionality is now working using pydantic-core.
Summary of changes
_internalmodule - this is to provide a clear differentiating between the public API and internal functionsconstr,UUID5FilePath) having been converted to type annotations, although some have an alias to simplicity(though the mypy tests are currently xfail), fixeddict()have not yet been renamed, we'll do that on a future PRBefore merging we need to decide on pydantic/pydantic-core#307.
In terms of next steps, I'm going to create issues now rather than listing here.