Update URLs after migrating to organization#4348
Merged
samuelcolvin merged 2 commits intopydantic:masterfrom Aug 8, 2022
Merged
Update URLs after migrating to organization#4348samuelcolvin merged 2 commits intopydantic:masterfrom
samuelcolvin merged 2 commits intopydantic:masterfrom
Conversation
samuelcolvin
reviewed
Aug 8, 2022
Member
samuelcolvin
left a comment
There was a problem hiding this comment.
LGTM, could you just add a change description saying "moved repo to pydantic/pydantic" or similar so the change is shown in the changelog.
Member
|
please update |
Member
|
@samuelcolvin seems your change in requirements.txt missed here |
Member
Ye, but that was unrelated, I just noticed it while looking through files, this is good. |
Contributor
Author
Done @samuelcolvin 🕺🏻 |
Member
|
Thanks so much @yezz123. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
After Migrating Pydantic from Samuel's account to a Pydantic Organization, it's better to change the URLs used in different files.
Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)