Skip to content

Mention Python >= 3.9.2 as an alternative to typing_extensions.TypedDict#3374

Merged
PrettyWood merged 6 commits intopydantic:masterfrom
BvB93:typedict
Dec 11, 2021
Merged

Mention Python >= 3.9.2 as an alternative to typing_extensions.TypedDict#3374
PrettyWood merged 6 commits intopydantic:masterfrom
BvB93:typedict

Conversation

@BvB93
Copy link
Copy Markdown
Contributor

@BvB93 BvB93 commented Oct 30, 2021 •
edited
Loading

Change Summary

Pydantic does not support older versions of typing.TypedDict due to bpo-42059, thus recomminding the use of typing_extensions.TypedDict instead. This issue was resolved in python 3.9.2 though, so mention upgrading python as an alternative to the typing_extensions-based approach.

Related issue number

n.a.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@BvB93
Copy link
Copy Markdown
Contributor Author

BvB93 commented Oct 30, 2021

please review

samuelcolvin
samuelcolvin reviewed Dec 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise makes sense.

Comment thread pydantic/annotated_types.py Outdated
@samuelcolvin
Copy link
Copy Markdown
Member

samuelcolvin commented Dec 10, 2021

please update

@github-actions github-actions Bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Dec 10, 2021
@github-actions github-actions Bot assigned BvB93 and unassigned samuelcolvin and PrettyWood Dec 10, 2021
@BvB93 @samuelcolvin
Update pydantic/annotated_types.py
27c5027 
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
PrettyWood
PrettyWood reviewed Dec 10, 2021
View reviewed changes
Comment thread tests/test_annotated_types.py Outdated
@PrettyWood PrettyWood merged commit e012089 into pydantic:master Dec 11, 2021
@PrettyWood PrettyWood removed the awaiting author revision awaiting changes from the PR author label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

+1 more reviewer

@PrettyWood PrettyWood PrettyWood left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@BvB93 BvB93

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BvB93 @samuelcolvin @PrettyWood