Add section "Based on Pydantic" with FastAPI#323
Merged
samuelcolvin merged 4 commits intopydantic:masterfrom Dec 23, 2018
Merged
Add section "Based on Pydantic" with FastAPI#323samuelcolvin merged 4 commits intopydantic:masterfrom
samuelcolvin merged 4 commits intopydantic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 1771 1771
Branches 344 344
=====================================
Hits 1771 1771 |
Member
|
Happy to have such a section but like aiohttp I think it should be one line per library. |
Contributor
Author
|
Sure. Done ✔️ |
Member
|
Sorry, forgot to say: no need for a release. I can update the docs without releasing the python package. |
Contributor
Author
|
Cool. Sure. |
Contributor
Author
|
Thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Add section "Based on Pydantic" to docs. Including FastAPI, an API web framework based on Pydantic.
Let me know if it doesn't seem sensible to have a section "Based on Pydantic".
Also, let me know if I'm being too verbose and you would prefer just a list of links with each third party (just FastAPI for now).
Related issue number
No relevant issue.
Performance Changes
Just docs.
pydantic cares about performance, if there's any risk performance changed on this PR,
please run
make benchmark-pydanticbefore and after the change:Checklist
HISTORY.rsthas been updated#<number>@whatever