Codecov Report

Merging #2306 (1ae018c) into master (b742c6f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2306   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          23       23           
  Lines        4477     4477           
  Branches      903      903           
=======================================
  Hits         4476     4476           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b742c6f...1ae018c. Read the comment docs.

seems reasonable to me. Please can you:

• add a change description
• add a link in this PR to explain why Deque changed in a patch version, something strange must have happened

I guess the best explanation for this is given by Guido van Rossum https://bugs.python.org/issue29011#msg283660
It's still not quite clear to me personally why the addition couldn't wait until 3.7.0 release though.

• add a change description

Is there a predefined process for this? Couldn't find anything in the docs

Ok I found the changelog process here. Maybe the contribution docs should link there?

I guess the best explanation for this is given by Guido van Rossum https://bugs.python.org/issue29011#msg283660
It's still not quite clear to me personally why the addition couldn't wait until 3.7.0 release though.

That's very weird, thanks for hunting it down.

Ok I found the changelog process here. Maybe the contribution docs should link there?

The PR template that you should have seen when creating the PR describes it pretty well, that's enough mostly.

Happy to accept a PR to update the contributing docs, otherwise I'll try to make it clearer when I get around to it.

Thanks a lot fo this.