fix: support properly custom root type with from_orm()#2237
Merged
samuelcolvin merged 4 commits intopydantic:masterfrom Feb 13, 2021
Merged
fix: support properly custom root type with from_orm()#2237samuelcolvin merged 4 commits intopydantic:masterfrom
from_orm()#2237samuelcolvin merged 4 commits intopydantic:masterfrom
Conversation
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #2237 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 4199 4199
Branches 854 854
=========================================
Hits 4199 4199 Continue to review full report at Codecov.
|
scorpp
approved these changes
Jan 4, 2021
scorpp
left a comment
There was a problem hiding this comment.
Looks good! Way better than temp wrapper class
from_orm()parse_obj and from_orm()
039410f to
b204e05
Compare
b204e05 to
1be23a8
Compare
parse_obj and from_orm()from_orm()
scorpp
approved these changes
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
#2100 (comment)
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)