Update type annotation for create_model function#2071
Merged
samuelcolvin merged 2 commits intopydantic:masterfrom Nov 29, 2020
Merged
Update type annotation for create_model function#2071samuelcolvin merged 2 commits intopydantic:masterfrom
samuelcolvin merged 2 commits intopydantic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2071 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 4096 4096
Branches 821 821
=========================================
Hits 4096 4096 Continue to review full report at Codecov.
|
211264c to
4999f2a
Compare
PrettyWood
reviewed
Oct 29, 2020
Member
|
this looks good. As far as I'm aware it shouldn't be included in v1.7.2 so I won't merge it yet. let me know if I'm missing something. |
Member
|
thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update type annotation for create_model function
Updated
create_modelreturn type annotation to return type which inherits from__base__argument.For instance, before this PR mypy will fail on the code below:
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)