Skip to content

include format with secret types#1424

Merged
samuelcolvin merged 2 commits intopydantic:masterfrom
Atheuz:master
Apr 30, 2020
Merged

include format with secret types#1424
samuelcolvin merged 2 commits intopydantic:masterfrom
Atheuz:master

Conversation

@Atheuz
Copy link
Copy Markdown
Contributor

@Atheuz Atheuz commented Apr 23, 2020

Change Summary

include 'format': 'password' in the schema for secret types.

Related issue number

#546

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/1424-atheuz.md file added describing change

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2020

Codecov Report

Merging #1424 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1424   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3747      3747           
  Branches       742       742           
=========================================
  Hits          3747      3747           
Impacted Files Coverage Δ
pydantic/types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96c4dc...af9ac26. Read the comment docs.

@Atheuz
Copy link
Copy Markdown
Contributor Author

Atheuz commented Apr 23, 2020

Relates to #546

Comment thread changes/1424-atheuz.md Outdated
Comment thread pydantic/types.py Outdated
@Atheuz Atheuz requested a review from samuelcolvin April 24, 2020 19:23
@samuelcolvin samuelcolvin merged commit 9238e3d into pydantic:master Apr 30, 2020
@samuelcolvin
Copy link
Copy Markdown
Member

thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants