Skip to content

Ruff depth limit#391

Merged
samuelcolvin merged 11 commits into
mainfrom
ruff-depth-limit
May 27, 2026
Merged

Ruff depth limit#391
samuelcolvin merged 11 commits into
mainfrom
ruff-depth-limit

Conversation

@samuelcolvin

@samuelcolvin samuelcolvin commented Apr 24, 2026

Copy link
Copy Markdown
Member

Use ruff parsing depth limits as per astral-sh/ruff#24810

@codspeed-hq

codspeed-hq Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by 18.61%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 16 untouched benchmarks
⏩ 15 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ parse_1k_assigns__monty 3.1 ms 2.6 ms +18.61%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing ruff-depth-limit (01174ad) with main (fdced21)

Open in CodSpeed

Footnotes

  1. 15 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 24, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread crates/monty-type-checking/src/db.rs
Comment thread crates/monty-type-checking/src/db.rs
Comment thread Cargo.toml Outdated
@samuelcolvin samuelcolvin mentioned this pull request Apr 24, 2026
Merged
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 24, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 5 additional findings in Devin Review.

Open in Devin Review

Comment thread crates/monty-python/src/exceptions.rs
Comment thread crates/monty-python/python/pydantic_monty/_monty.pyi
@github-actions

github-actions Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Results 📊

❌ Patch coverage is 67.27%. Project has 24878 uncovered lines.
❌ Project coverage is 64.98%. Comparing base (base) to head (head).

Files with missing lines (4)
File Patch % Lines
crates/monty-python/src/exceptions.rs 81.54% ⚠️ 12 Missing and 3 partials
crates/monty/src/parse.rs 50.00% ⚠️ 10 Missing
crates/monty/src/exception_public.rs 56.25% ⚠️ 7 Missing and 1 partials
crates/monty-type-checking/src/db.rs 12.50% ⚠️ 7 Missing
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    64.99%    64.98%    -0.01%
==========================================
  Files          269       269         —
  Lines        70988     71041       +53
  Branches    152951    153050       +99
==========================================
+ Hits         46138     46163       +25
- Misses       24850     24878       +28
- Partials      3958      3989       +31

Generated by Codecov Action

@codecov

codecov Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.54545% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/monty-python/src/exceptions.rs 76.92% 12 Missing and 3 partials ⚠️
crates/monty-type-checking/src/db.rs 12.50% 7 Missing ⚠️
crates/monty/src/parse.rs 75.00% 4 Missing and 1 partial ⚠️
crates/monty/src/exception_public.rs 93.75% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 24, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 6 additional findings in Devin Review.

Open in Devin Review

Comment thread crates/monty-python/python/pydantic_monty/_monty.pyi
@samuelcolvin samuelcolvin enabled auto-merge (squash) May 27, 2026 19:03
@samuelcolvin samuelcolvin merged commit 9b5f478 into main May 27, 2026
30 checks passed
@samuelcolvin samuelcolvin deleted the ruff-depth-limit branch May 27, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samuelcolvin