Merge export_dataset into get_dataset with include_cases parameter#1792
Merged
Merge export_dataset into get_dataset with include_cases parameter#1792
export_dataset into get_dataset with include_cases parameter#1792Conversation
The name `export_dataset` was confusing - from the caller's perspective, they are importing a dataset from Logfire into their local environment, not exporting it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying logfire-docs with
|
| Latest commit: |
0e11af7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f64a915.logfire-docs.pages.dev |
| Branch Preview URL: | https://rename-export-dataset-to-imp.logfire-docs.pages.dev |
Instead of separate `get_dataset` (metadata only) and `export_dataset` (with cases) methods, unify into a single `get_dataset` that accepts an `include_cases` boolean (defaults to True) and optional type arguments for returning a typed `pydantic_evals.Dataset`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
export_dataset to import_datasetexport_dataset into get_dataset with include_cases parameter
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
… version Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
….md example Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export_datasetmethod and merge its functionality intoget_datasetget_datasetnow accepts aninclude_casesparameter (defaults toTrue) that controls whether to fetch cases via the/export/endpoint or just metadatainput_type, etc.) are passed,get_datasetreturns a typedpydantic_evals.Datasetcc @dmontagu
🤖 Generated with Claude Code