Skip to content

Delete redundant logfire.experimental.datasets package#1763

Merged
alexmojaki merged 1 commit intomainfrom
alex/delete-datasets-module
Mar 6, 2026
Merged

Delete redundant logfire.experimental.datasets package#1763
alexmojaki merged 1 commit intomainfrom
alex/delete-datasets-module

Conversation

@alexmojaki
Copy link
Copy Markdown
Collaborator

@alexmojaki alexmojaki commented Mar 6, 2026

Summary by cubic

Removed the redundant logfire.experimental.datasets package that only re-exported api_client symbols, and deleted its re-export tests. This cleans up duplicate import paths without changing client behavior.

  • Migration
    • Replace imports from logfire.experimental.datasets with logfire.experimental.api_client.
    • Use LogfireAPIClient, AsyncLogfireAPIClient, DatasetNotFoundError, CaseNotFoundError, and DatasetApiError from api_client.

Written for commit e7a1962. Summary will update on new commits.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7a1962
Status: ✅  Deploy successful!
Preview URL: https://dab155b8.logfire-docs.pages.dev
Branch Preview URL: https://alex-delete-datasets-module.logfire-docs.pages.dev

View logs

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@alexmojaki alexmojaki enabled auto-merge (squash) March 6, 2026 18:39
@alexmojaki alexmojaki merged commit 54a6011 into main Mar 6, 2026
18 checks passed
@alexmojaki alexmojaki deleted the alex/delete-datasets-module branch March 6, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant