Address review feedback on semconv PR (#1705)#1707
Merged
Conversation
- Validate inputs in normalize_versions() (reject invalid versions, empty lists) - Fix docstrings for instrument_openai/instrument_anthropic to accurately describe version='latest' behavior (minimal request_data still emitted) - Fix test docstrings to match actual behavior - Remove duplicate io import in test_openai.py
Deploying logfire-docs with
|
| Latest commit: |
c141add
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d066178d.logfire-docs.pages.dev |
| Branch Preview URL: | https://fix-semconv-pr-feedback.logfire-docs.pages.dev |
Avoids lying to the type system by casting a known-invalid value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review comments from #1705:
normalize_versions()inputs: Now rejects invalid version values (e.g.2,'v2') and empty inputs with clearValueErrormessagesinstrument_openai()andinstrument_anthropic()docstrings now accurately describe thatversion='latest'still emits minimalrequest_datafor message template compatibilityimport io:BytesIOwas already imported at module levelNon-actionable review comments were replied to and resolved on the original PR.
Test plan
test_normalize_versions_validation— new test covering valid and invalid inputsversion_latestandversion_v1tests pass