Fix inconsistent handling of empty list vs empty string in token normalization#1681
Closed
Copilot wants to merge 2 commits intomulti-token-supportfrom
Closed
Fix inconsistent handling of empty list vs empty string in token normalization#1681Copilot wants to merge 2 commits intomulti-token-supportfrom
Copilot wants to merge 2 commits intomulti-token-supportfrom
Conversation
7 tasks
…pty string Co-authored-by: alexmojaki <3627481+alexmojaki@users.noreply.github.com>
Deploying logfire-docs with
|
| Latest commit: |
fe14352
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://caf6e833.logfire-docs.pages.dev |
| Branch Preview URL: | https://copilot-sub-pr-1672.logfire-docs.pages.dev |
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update to address review feedback on multi-token support
Fix inconsistent handling of empty list vs empty string in token normalization
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The token normalization logic treated empty string
''and empty list[]inconsistently. Empty string loaded from param_manager (env var/config file), while empty list filtered to None directly without checking param_manager.Changes
extract_list_of_strconsistently, treatingNone,'', and[]identically - all load from param_managerBehavior
Before:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.