-
Notifications
You must be signed in to change notification settings - Fork 220
logfire run always suggests requests, sqlite3, urllib #1296
Copy link
Copy link
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Understandable, because sqlite3 and urllib are part of the standard library and requests comes with opentelemetry, but still confusing because people often won't be using them. I saw sqlite3 and initially though some random package was pulling it in before I realized it was stdlib.
@Kludex Should we check if the script contains import <package> and only include them then? In multi-file projects, people are even less likely to use them.
# script.py
print('Hello, world!')uvx logfire run script.py
╭──────────────────────────────────────────────────────────────── Logfire Summary ────────────────────────────────────────────────────────────────╮
│ │
│ Your instrumentation checklist: │
│ │
│ ☐ requests (need to install opentelemetry-instrumentation-requests) │
│ ☐ sqlite3 (need to install opentelemetry-instrumentation-sqlite3) │
│ ☐ urllib (need to install opentelemetry-instrumentation-urllib) │
│ │
│ │
│ To install all recommended packages at once, run: │
│ │
│ uv add opentelemetry-instrumentation-requests opentelemetry-instrumentation-sqlite3 opentelemetry-instrumentation-urllib │
│ │
│ ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── │
│ │
│ To hide this summary box, use: logfire run --no-summary. │
│ │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers