Fix: check LOGFIRE_IGNORE_NO_CONFIG from environment when needed

Lftobs · web-flow · commit d2a8878e7215 · 2025-09-10T09:26:18.000Z
diff --git a/logfire/_internal/config.py b/logfire/_internal/config.py
@@ -1197,7 +1197,9 @@ def get_event_logger_provider(self) -> EventLoggerProvider | None:
         return self._event_logger_provider
 
     def warn_if_not_initialized(self, message: str):
-        if not self._initialized and not self.ignore_no_config:
+        ignore_no_config_env = os.getenv('LOGFIRE_IGNORE_NO_CONFIG', '')
+        ignore_no_config = ignore_no_config_env.lower() in ('1', 'true', 't') or self.ignore_no_config
+        if not self._initialized and not ignore_no_config:
             warn_at_user_stacklevel(
                 f'{message} until `logfire.configure()` has been called. '
                 f'Set the environment variable LOGFIRE_IGNORE_NO_CONFIG=1 or add ignore_no_config=true in pyproject.toml to suppress this warning.',
diff --git a/tests/test_logfire.py b/tests/test_logfire.py
@@ -1,8 +1,10 @@
 from __future__ import annotations
 
 import inspect
+import os
 import re
 import sys
+import warnings
 from concurrent.futures import ProcessPoolExecutor, ThreadPoolExecutor
 from contextlib import asynccontextmanager, contextmanager
 from dataclasses import dataclass
@@ -3476,3 +3478,70 @@ def test_min_level(exporter: TestExporter, config_kwargs: dict[str, Any]) -> Non
     assert [span['name'] for span in exporter.exported_spans_as_dict()] == snapshot(
         ['warning span', 'notice message', 'warn message', 'default span']
     )
+
+
+def test_warn_if_not_initialized():
+    """Test that warnings are properly issued when logfire is not initialized."""
+
+    config = LogfireConfig()
+
+    with pytest.warns(LogfireNotConfiguredWarning) as warnings_list:
+        config.warn_if_not_initialized('Test message')
+
+        assert str(warnings_list[0].message) == (
+            'Test message until `logfire.configure()` has been called. '
+            'Set the environment variable LOGFIRE_IGNORE_NO_CONFIG=1 or add ignore_no_config=true in pyproject.toml to suppress this warning.'
+        )
+
+    with patch.dict(os.environ, {'LOGFIRE_IGNORE_NO_CONFIG': '1'}):
+        config.warn_if_not_initialized('Should not warn with env var')
+
+    with patch.dict(os.environ, {'LOGFIRE_IGNORE_NO_CONFIG': '0'}):
+        with pytest.warns(LogfireNotConfiguredWarning) as warnings_list:
+            config.warn_if_not_initialized('Should warn with env var 0')
+
+            assert str(warnings_list[0].message) == (
+                'Should warn with env var 0 until `logfire.configure()` has been called. '
+                'Set the environment variable LOGFIRE_IGNORE_NO_CONFIG=1 or add ignore_no_config=true in pyproject.toml to suppress this warning.'
+            )
+
+    with patch.dict(os.environ, {'LOGFIRE_IGNORE_NO_CONFIG': ''}):
+        with pytest.warns(LogfireNotConfiguredWarning) as warnings_list:
+            config.warn_if_not_initialized('Should warn with empty env var')
+
+            assert str(warnings_list[0].message) == (
+                'Should warn with empty env var until `logfire.configure()` has been called. '
+                'Set the environment variable LOGFIRE_IGNORE_NO_CONFIG=1 or add ignore_no_config=true in pyproject.toml to suppress this warning.'
+            )
+            assert len(warnings_list) == 1
+
+
+def test_warn_if_not_initialized_with_file_config():
+    """Test that warnings are suppressed when ignore_no_config is set in config file."""
+    import tempfile
+    from pathlib import Path
+
+    with tempfile.TemporaryDirectory() as temp_dir:
+        config_dir = Path(temp_dir)
+        pyproject_toml = config_dir / 'pyproject.toml'
+        pyproject_toml.write_text('[tool.logfire]\nignore_no_config = true\n')
+
+        config = LogfireConfig(config_dir=config_dir)
+
+        with warnings.catch_warnings(record=True) as warning_list:
+            warnings.simplefilter('always')
+            config.warn_if_not_initialized('Should not warn due to config file')
+
+            logfire_warnings = [w for w in warning_list if issubclass(w.category, LogfireNotConfiguredWarning)]
+            assert len(logfire_warnings) == 0
+
+
+def test_warn_if_not_initialized_category():
+    """Test that the warning has the correct category."""
+    config = LogfireConfig()
+
+    with pytest.warns(LogfireNotConfiguredWarning) as warnings_list:
+        config.warn_if_not_initialized('Test message')
+
+        assert warnings_list[0].category == LogfireNotConfiguredWarning
+        assert issubclass(LogfireNotConfiguredWarning, UserWarning)
