Make the code more strictly typed without changing the type checker#1030
Merged
Conversation
Add explicit type annotations to empty collections, replace inline `# type:` comments with class- and variable-level annotations, return `collections.abc.Generator` from context managers instead of `typing.Iterator`, and import submodules explicitly so the strict type checker and linter pass cleanly.
|
Docs preview: |
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up typing across
httpx2andhttpcore2so the strict type checker and linter pass without inline workarounds:list[Any]/dict[Any, Any].# type:comments with class- and variable-level annotations.collections.abc.Generatorfrom context managers instead oftyping.Iterator.anyio.abc,hyperframe.frame,http.cookiejar)._-prefixed.httpcore2sync changes are made in the_asyncsources and regenerated via unasync.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.