Limit chained Content-Encoding decoders to 5#1027
Conversation
|
Docs preview: |
Merging this PR will not alter performance
Comparing 
Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0190de0d72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Identity and unsupported encodings no longer count toward the limit, so a response that lists junk labels but applies few real decoders keeps decoding instead of raising.
MultiDecoder no longer special-cases 'identity'; the response decoder drops it before building the chain.
Filtering identity collapsed the old br,identity chains to single decoders, dropping coverage of the empty-data guard in BrotliDecoder/ZStandardDecoder. A br,zstd chain exercises it directly.
There was a problem hiding this comment.
3 issues found across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
A response can carry multiple
Content-Encodingvalues, which we decode by building aMultiDecoderchain. Today that chain is unbounded - a response can list an arbitrary number of encodings and we'll happily build a decoder for each one.Real responses apply one encoding, occasionally two. There's no legitimate reason to chain more than a handful, so this caps the chain at 5 and raises
DecodingErrorpast that.The limit lives as a
ClassVaronMultiDecoderso it stays easy to find and adjust.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.