Switch httpcore2 from certifi to truststore for default SSL verification#1002
Conversation
…ication Mirrors #209, which only switched httpx2. httpcore2 still declared `certifi` directly and loaded it in `default_ssl_context()`, so it was installed and imported even though httpx2 always passes its own truststore context down. `certifi` now remains only as a transitive test dependency of `requests`.
|
Docs preview: https://a1e796a0-httpx2-docs.pydantic.workers.dev |
Merging this PR will not alter performance
Comparing 
Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 635c68bdbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bare `truststore.SSLContext` ignores the OpenSSL CA env overrides, so direct httpcore2 users relying on them for a corporate/private CA would lose verification. Mirror the `httpx2.create_ssl_context()` fallback.
Match httpx2's `# pragma: no cover` precedent for the env-override paths instead of testing them.
#209 switched
httpx2totruststorebut lefthttpcore2declaringcertifidirectly and loadingcertifi.where()indefault_ssl_context(). Sincehttpx2always builds its own truststore context and passes it down,certifiwas only ever exercised whenhttpcore2is used directly withssl_context=None- but it was still installed and imported regardless.This mirrors #209 at the
httpcore2layer.certifinow survives only as a transitive test dependency ofrequests, no longer pulled in by either package.mypy, ruff, and the full
httpcore2test suite (223 tests) pass.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.