Merged
Conversation
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Collaborator
|
Is there any way to not hardcode the path ? |
Collaborator
Author
|
It worked and works for me locally (tm). py run-test-pre: PYTHONHASHSEED='2634314539'
py run-test-pre: commands[0] | /Users/thomas.sjogren/Git/python-vagrant/tests/tools/create_dummy_box.sh virtualbox
+++ dirname /Users/thomas.sjogren/Git/python-vagrant/tests/tools/create_dummy_box.sh
++ cd /Users/thomas.sjogren/Git/python-vagrant/tests/tools
++ pwd
+ DIR=/Users/thomas.sjogren/Git/python-vagrant/tests/tools
+ PROVIDER=virtualbox
++ mktemp -d
+ TMPDIR=/var/folders/2j/8m_c9kxs0337lp_7s6h6prv80000gp/T/tmp.gF8xBGZSaC
+ '[' 1 -ne 1 ']'
+ '[' -f /Users/thomas.sjogren/Git/python-vagrant/tests/tools/dummy-virtualbox.box ']'
+ cd /var/folders/2j/8m_c9kxs0337lp_7s6h6prv80000gp/T/tmp.gF8xBGZSaC
+ echo '{ "provider": "virtualbox"}'
+ tar czf /Users/thomas.sjogren/Git/python-vagrant/tests/tools/dummy-virtualbox.box .
+ cd /Users/thomas.sjogren/Git/python-vagrant/tests/tools
+ rm -rvf /var/folders/2j/8m_c9kxs0337lp_7s6h6prv80000gp/T/tmp.gF8xBGZSaC
removed '/var/folders/2j/8m_c9kxs0337lp_7s6h6prv80000gp/T/tmp.gF8xBGZSaC/metadata.json'
removed directory '/var/folders/2j/8m_c9kxs0337lp_7s6h6prv80000gp/T/tmp.gF8xBGZSaC'
py run-test-pre: commands[1] | /Users/thomas.sjogren/Git/python-vagrant/tests/tools/create_dummy_box.sh libvirt
+++ dirname /Users/thomas.sjogren/Git/python-vagrant/tests/tools/create_dummy_box.sh
++ cd /Users/thomas.sjogren/Git/python-vagrant/tests/tools
++ pwd
+ DIR=/Users/thomas.sjogren/Git/python-vagrant/tests/tools
+ PROVIDER=libvirt
++ mktemp -d
+ TMPDIR=/var/folders/2j/8m_c9kxs0337lp_7s6h6prv80000gp/T/tmp.2rpvdTs3m2
+ '[' 1 -ne 1 ']'
+ '[' -f /Users/thomas.sjogren/Git/python-vagrant/tests/tools/dummy-libvirt.box ']'
+ echo 'Box already created'
Box already created
+ exit 0 |
Collaborator
Author
|
My bad, when recreating the environment it failed. |
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Collaborator
Author
|
7 commits for 1 LoC... but lets try that glob again. |
ssbarnea
approved these changes
Dec 6, 2022
apatard
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
allowlist_externalstosh,/home/runner/work/python-vagrant/python-vagrant/tests/tools/create_dummy_box.shand/Users/runner/work/python-vagrant/python-vagrant/tests/tools/create_dummy_box.shSee https://github.com/pycontribs/python-vagrant/actions/runs/3622456363/jobs/6107188602#step:10:21 and https://tox.wiki/en/latest/config.html#allowlist_externals
Signed-off-by: Thomas Sjögren konstruktoid@users.noreply.github.com