configure vbguest and validate Vagrantfile during lifecycle test#115
Merged
ssbarnea merged 3 commits intopycontribs:mainfrom Mar 31, 2022
Merged
configure vbguest and validate Vagrantfile during lifecycle test#115ssbarnea merged 3 commits intopycontribs:mainfrom
ssbarnea merged 3 commits intopycontribs:mainfrom
Conversation
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
apatard
reviewed
Mar 31, 2022
|
|
||
| def test_vm_lifecycle(vm_dir): | ||
| """Test methods controlling the VM - init(), up(), halt(), destroy().""" | ||
| """Test methods controlling the VM - init(), up(), suspend(), halt(), destroy().""" |
Collaborator
There was a problem hiding this comment.
What was the reason for removing the suspend() here ?
Collaborator
Author
There was a problem hiding this comment.
I didn't? I just updated the comment to include suspend().
v.suspend()
assert v.SAVED == v.status()[0].state
apatard
approved these changes
Mar 31, 2022
ssbarnea
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
vbguestin order to passinit()andup()sequenceinit()Signed-off-by: Thomas Sjögren konstruktoid@users.noreply.github.com