Skip to content

Conversation

@reaperhulk
Copy link
Member

No description provided.

@alex alex merged commit 12bc43b into pyca:23.1.x Mar 28, 2023
@reaperhulk reaperhulk deleted the handle-null branch March 28, 2023 03:37
@ShaneHarvey
Copy link
Contributor

ShaneHarvey commented Mar 28, 2023

Should the other calls to OBJ_nid2sn also be fixed?:

@reaperhulk
Copy link
Member Author

Passing an undef NID to EllipticCurve.from_nid is already documented as requiring a known NID. In the UNDEF case it will fail sooner on OpenSSL 3.1.0, but that's it. (This is a terrible API in general, as is most of pyOpenSSL, but c'est la vie).

X509Name.get_components appears reachable so I'd be happy to review a patch that fixes that (and adds a test).

PKCS7.get_type_name would be reachable only if someone creates a PKCS7 structure that deliberately does not use known types. That's certainly possible, albeit somewhat involved. If a test exercising the path is created we'd take a patch for this as well.

@alex
Copy link
Member

alex commented Mar 29, 2023 via email

@ShaneHarvey
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants