Closed
Conversation
Member
Author
|
So this doesn't compile cleanly, because there are places that libressl now has symbols for stuff. Should we drop support for older libressl, or do I need to figure out how to branch on libressl version? |
Member
|
I don't think we can drop support for all older libre (although we can be more aggressive than OpenSSL). Alpine ships 2.6.3 in |
Member
Author
|
I hate my life
…On Wed, Mar 21, 2018 at 10:25 PM, Paul Kehrer ***@***.***> wrote:
I don't think we can drop support for all older libre (although we can be
more aggressive than OpenSSL). Alpine ships 2.6.3 in alpine:latest
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4168 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAADBHaBCbaCVk-RW5CuaxBRiF8R-1DCks5tgwucgaJpZM4S2VL1>
.
--
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6
|
Contributor
|
Yeah, LibreSSL 2.7 introduced most, maybe all OpenSSL 1.1 symbols. I think you should treat LibreSSL 2.7.1 like OpenSSL 1.1 and consider all deviations as bugs in LibreSSL. |
Contributor
|
I have a working patch in my tree. Hang on, pull request coming up! |
Contributor
|
Can you please test the patch from #4210 |
Member
Author
|
(Closing this in favor of that patch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.