Conversation
|
Thanks for contribution. Before I can get into the real review (it will take some time on my side), I have two questions:
|
|
ok, thanks for the suggestions.. i will split the PR |
4f1b60c to
d9fd47c
Compare
albertosottile
left a comment
There was a problem hiding this comment.
I left a few comments. General thought: I am willing to merge this PR as it is (if we are able to make all the tests pass, currently working on that). However, please be advised that MinGW is not a test target of this project and I personally do not intend to actively support it. Therefore, there is a chance that every single future commit could break this compatibility.
No worries, MSYS2 will maintain this package :) |
b1f45e3 to
8177b4b
Compare
224ea4b to
5234530
Compare
That's good to hear. But then, would you like to add one (or more) MinGW test target in the Actions workflow? |
|
Thank you again for this PR! |
|
Thank you too! |
|
Also to add a little note for when 3.13+ needs support. In windows due to how LoadLibraryA/W loads DLLs with the TLS information that initialization of the python core when What this means for
|
Fixes #191
Tested with a simple
hello worldprogram on both python 3.11 and 3.12Thanks to @AraHaan for the
_memimporterfix: #191 (comment)Thanks to @sdbbs for the
dllfinderfix: #1 (comment)Note: I don't know why the matplotlib test fails though