Skip to content

fix a bug in MemoryModule.c:PerformBaseRelocation#210

Merged
albertosottile merged 1 commit into
py2exe:masterfrom
H4ckF0rFun:master
Jul 22, 2024
Merged

fix a bug in MemoryModule.c:PerformBaseRelocation#210
albertosottile merged 1 commit into
py2exe:masterfrom
H4ckF0rFun:master

Conversation

@H4ckF0rFun

Copy link
Copy Markdown
Contributor

For a detailed explanation of the bug, please refer to the following page:

https://github.com/fancycode/MemoryModule/pull/116/files

@albertosottile

Copy link
Copy Markdown
Member

Thanks for this contribution. I will review and merge when I have a functional CI again.

Seems the page is linked to a lot of interesting discussions... including running .pyd files from memory which, incidentally, is what py2exe already does (but I am sure you know).

@albertosottile albertosottile added the bug Something isn't working label Jul 19, 2024
@albertosottile

Copy link
Copy Markdown
Member

@H4ckF0rFun Now CI is working again. Could you rebase your branch on top of the latest master? Thanks

@albertosottile

Copy link
Copy Markdown
Member

I realized I could rebase this myself, and so I did this. Thank you again for this PR.

@H4ckF0rFun

Copy link
Copy Markdown
Contributor Author

Thanks 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants