Let patched sys.stderr.write() and sys.stdout.write() return number of written bytes#134
Merged
albertosottile merged 1 commit intoJul 3, 2022
Conversation
Member
|
This LGTM, thanks for this contribution. Any idea why the CI workflow was not triggered? I was expecting an approval request, but I cannot even see that... |
9da5416 to
5965646
Compare
Contributor
Author
|
The “workflow awaiting approval” went missing. Now, after force-push, it appeared again. Do you get the approval request now? |
Contributor
Author
|
Note: the tests will fail on master when you retrigger CI. |
Member
|
I fixed the CI on master, could you rebase? |
…f written bytes On Python 3, a file’s write() method is expected to return the number of written bytes. It’s a bit unclear what do when no data is actually written (log file couldn’t be opened in case of stderr or data is deliberately ignored in case of stdout). I think it’s reasonable in this case to pretend that all passed data was written. If we returned 0, a caller which calls write() repeatedly until all data has been written will end up in an infinite loop.
5965646 to
7c8dfb7
Compare
Member
|
Thank you for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3, a file’s write() method is expected to return the number of
written bytes.
It’s a bit unclear what do when no data is actually written (log file
couldn’t be opened in case of stderr or data is deliberately ignored in
case of stdout). I think it’s reasonable in this case to pretend that
all passed data was written. If we returned 0, a caller which calls
write() repeatedly until all data has been written will end up in an
infinite loop.