Closed
Conversation
TODO : add some encodings missing
Merged
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
- Coverage 84.26% 83.85% -0.41%
==========================================
Files 18 18
Lines 4117 4149 +32
Branches 868 878 +10
==========================================
+ Hits 3469 3479 +10
- Misses 465 482 +17
- Partials 183 188 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main PR is here: #969
This PR is meant to be closed. It's just for me (Martin) to try things out. #969 should get merged.