Skip to content

BUG : Merger to be initialize with strict=False default#871

Merged
MartinThoma merged 1 commit intopy-pdf:deprecationsfrom
pubpub-zz:FixMergeStrict
May 13, 2022
Merged

BUG : Merger to be initialize with strict=False default#871
MartinThoma merged 1 commit intopy-pdf:deprecationsfrom
pubpub-zz:FixMergeStrict

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

tracked in
mvicenzi/pdf_tools#2

as said in title

@MartinThoma MartinThoma merged commit a9c31a4 into py-pdf:deprecations May 13, 2022
@MartinThoma
Copy link
Copy Markdown
Member

Thank you!

@MartinThoma
Copy link
Copy Markdown
Member

... damn, that merge was actually wrong. The "deprecations" branch will be merged into main. No breaking changes should happen there.

But I do want to change the behavior for PyPDF2 2.0.0

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

But I do want to change the behavior for PyPDF2 2.0.0

@MartinThoma can you please clarify your thoughts?

@MartinThoma
Copy link
Copy Markdown
Member

I want to say that changing the default is not acceptable in PyPDF2 1.x, but I definitely want to have this change with PyPDF2 2.0.0 (I actually thought I had added it there already)

@MartinThoma
Copy link
Copy Markdown
Member

I have a nice idea! We leave the new strict=False default in the PdfMerger, but for users of the PdfFileMerger the default stays at strict=True. This way I don't need to make a major version bump while still being able to move into this direction :-) (with a notice in the changelog, of course :-) )

@MartinThoma
Copy link
Copy Markdown
Member

Here is what I meant: ba6a427

@pubpub-zz pubpub-zz deleted the FixMergeStrict branch August 8, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants