Skip to content

if not self.strict, ignore a /Prev entry with the value 0 in the trailer#618

Merged
MartinThoma merged 4 commits intopy-pdf:masterfrom
vashek:bugfix/530
Apr 9, 2022
Merged

if not self.strict, ignore a /Prev entry with the value 0 in the trailer#618
MartinThoma merged 4 commits intopy-pdf:masterfrom
vashek:bugfix/530

Conversation

@vashek
Copy link
Copy Markdown
Contributor

@vashek vashek commented May 12, 2021

closes #530

@MartinThoma MartinThoma added Tiny Pull requests that make a tiny change - and thus should be easy to merge is-robustness-issue From a users perspective, this is about robustness labels Apr 6, 2022
@MartinThoma
Copy link
Copy Markdown
Member

There is currently no unit test for that part. Could you add one?

@MartinThoma MartinThoma added the needs-test A test should be added before this PR is merged. label Apr 9, 2022
@vashek
Copy link
Copy Markdown
Contributor Author

vashek commented Apr 9, 2022

There is currently no unit test for that part. Could you add one?

Here you go.

@MartinThoma MartinThoma merged commit 237d9cb into py-pdf:master Apr 9, 2022
@MartinThoma
Copy link
Copy Markdown
Member

Very nice! Thank you for your contribution 🤗

@MartinThoma MartinThoma removed the needs-test A test should be added before this PR is merged. label Apr 9, 2022
@vashek
Copy link
Copy Markdown
Contributor Author

vashek commented Apr 9, 2022

Very nice! Thank you for your contribution 🤗

Thank you for reviving the project! :)

@vashek vashek deleted the bugfix/530 branch April 9, 2022 12:17
@MartinThoma
Copy link
Copy Markdown
Member

I'm not sure yet when I will create the next release, but latest in May. Probably end of next week - if nobody complains about it, I'd rather release often :-)

You seem to be very experienced, so I guess you already know that you can install the latest PyPDF2 version via pip install git+https://github.com/py-pdf/PyPDF2.git in case you want to be on the pre-release version :-)

@vashek
Copy link
Copy Markdown
Contributor Author

vashek commented Apr 9, 2022

I'm not sure yet when I will create the next release, but latest in May. Probably end of next week - if nobody complains about it, I'd rather release often :-)

That's perfectly fine with me, thanks!

You seem to be very experienced, so I guess you already know that you can install the latest PyPDF2 version via pip install git+https://github.com/py-pdf/PyPDF2.git in case you want to be on the pre-release version :-)

Actually, I generally use pipenv for my projects and what I do when I need a version with some unreleased or even unmerged fix is that I specify the package in the Pipfile like this, for example:

[packages]
pillow = "~=8.2.0"
pypdf2 = {editable = true, ref = "bugfix/gss-1789-rollup", git = "https://github.com/vashek/PyPDF2.git"}

(just in case it helps anyone...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is-robustness-issue From a users perspective, this is about robustness Tiny Pull requests that make a tiny change - and thus should be easy to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A certain PDF File triggers OSError: [Errno 22] Invalid argument

2 participants