MAINT: Use placeholder-based approach for logger_error#3673
Merged
stefan6419846 merged 9 commits intopy-pdf:mainfrom Mar 16, 2026
Merged
MAINT: Use placeholder-based approach for logger_error#3673stefan6419846 merged 9 commits intopy-pdf:mainfrom
stefan6419846 merged 9 commits intopy-pdf:mainfrom
Conversation
Contributor
Author
|
The synch forked repo is always failing Is there a special configuration ? |
stefan6419846
requested changes
Mar 9, 2026
Collaborator
stefan6419846
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have added some comments.
As for the tests: I propose to move the values to actual PdfObjects as this is what we pass in most of the cases.
Regarding the tests failing on forks: This is due to downloading large amounts of PDF files and rate limits from GitHub. There unfortunately is not much we can do about this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3673 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 55 55
Lines 9989 9989
Branches 1833 1833
=======================================
Hits 9731 9731
Misses 150 150
Partials 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lation to the source input parameter to be keyword argument
it reinforcd the separation between postional argument (first paramter or message) and the keyword argument(source)
Contributor
Author
|
@stefan6419846 any issue remaining ? |
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
stefan6419846
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR out of two. This address partially the issue #3384 for logger_error only. The second PR will address the same issue but for logger_warning
This fixes #3384