MAINT: Remove excessive logging in extract_links while not clear#3670
Merged
stefan6419846 merged 4 commits intopy-pdf:mainfrom Mar 6, 2026
Merged
MAINT: Remove excessive logging in extract_links while not clear#3670stefan6419846 merged 4 commits intopy-pdf:mainfrom
stefan6419846 merged 4 commits intopy-pdf:mainfrom
Conversation
Relates to py-pdf#3667. It currently is unclear how to correctly handle the links in this case, as `zip()` in strict mode would raise due to the current mismatches which seem to occur for legitimate files. In most of the cases, there will be no new annotations and thus always an empty list as the return value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #3667.
It currently is unclear how to correctly handle the links in this case, as
zip()in strict mode would raise due to the current mismatches which seem to occur for legitimate files. In most of the cases, there will be no new annotations and thus always an empty list as the return value.