Skip to content

MAINT: Move and rename _xobj_image_helpers.py#3661

Merged
stefan6419846 merged 13 commits intopy-pdf:mainfrom
j-t-1:rename
Mar 3, 2026
Merged

MAINT: Move and rename _xobj_image_helpers.py#3661
stefan6419846 merged 13 commits intopy-pdf:mainfrom
j-t-1:rename

Conversation

@j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Feb 26, 2026 •
edited
Loading

Move from top level to more appropriate generic folder. Also rename,
to remove the redundant "helpers".

@j-t-1 j-t-1 changed the title Rename MAINT: Move and rename Feb 26, 2026
@stefan6419846
Copy link
Collaborator

stefan6419846 commented Feb 27, 2026

There still seems to be something wrong about the code and the title looks rather generic/not very descriptive.

@j-t-1 j-t-1 changed the title MAINT: Move and rename MAINT: Move and rename _xobj_image_helpers.py Feb 27, 2026
@codecov
Copy link

codecov bot commented Feb 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.36%. Comparing base (7c2bcdd) to head (4f50959).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3661   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files          55       55           
  Lines        9925     9925           
  Branches     1817     1817           
=======================================
  Hits         9663     9663           
  Misses        152      152           
  Partials      110      110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Feb 27, 2026

There still seems to be something wrong about the code and the title looks rather generic/not very descriptive.

Amended the code and title. Currently failed test could be a timeout, which may pass on a re-run.

@stefan6419846
Copy link
Collaborator

stefan6419846 commented Feb 27, 2026

Currently failed test could be a timeout, which may pass on a re-run.

Please rebase on the latest main through "Update branch", which hopefully fixes the previous caching and network issues.

stefan6419846
stefan6419846 reviewed Mar 2, 2026
View reviewed changes
stefan6419846
stefan6419846 reviewed Mar 2, 2026
View reviewed changes
@stefan6419846 stefan6419846 merged commit 6d0fa2f into py-pdf:main Mar 3, 2026
18 checks passed
@j-t-1 j-t-1 deleted the rename branch March 3, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j-t-1 @stefan6419846