ROB: Deal with DictionaryObjects having streams of length 0#3114
Closed
stefan6419846 wants to merge 1 commit intopy-pdf:mainfrom
Closed
ROB: Deal with DictionaryObjects having streams of length 0#3114stefan6419846 wants to merge 1 commit intopy-pdf:mainfrom
stefan6419846 wants to merge 1 commit intopy-pdf:mainfrom
Conversation
Contributor
if length > 0:
data["__streamdata__"] = stream. Read(length)
elif length < 0:
data["__streamdata__"] = read_until_regex(
stream, re.compile(b"endstream")
)
...
if "__streamdata__" in data:
return StreamObject.initialize_from_dictionary(data)
retval = DictionaryObject()
retval.update(data)
return retvalI think the problem lies in this piece of code. A StreamObject of length 0 will not have I've run pytest in my Windows,. The tests failed because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3052.