Merged
Conversation
Also sort the ignore list.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 52 52
Lines 8726 8726
Branches 1721 1721
=======================================
Hits 8415 8415
Misses 182 182
Partials 129 129 ☔ View full report in Codecov by Sentry. |
Collaborator
|
The exclude should not hurt IMHO. Nevertheless, the file should be unused after #2572 and could probably be removed completely. |
pypdf moved from flake8 to ruff. This is a continuation of py-pdf#2572.
Contributor
Author
|
Deleted the file. Feel free to change the commit message, which is now: pypdf moved from flake8 to ruff. This is a continuation of #2572. |
stefan6419846
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also sort the ignore list.