Initial support for CMap character translation#201
Closed
Upliner wants to merge 1 commit intopy-pdf:mainfrom
Closed
Initial support for CMap character translation#201Upliner wants to merge 1 commit intopy-pdf:mainfrom
Upliner wants to merge 1 commit intopy-pdf:mainfrom
Conversation
Collaborator
|
Experiencing a few issues with this PR. Some text in the output is duplicated. I'll provide the failing document shortly if needed. |
|
Any news about this one? |
|
Upliner, the patch seems good. Only one suggestion: you discard a line feed evaluating Please add a comment in the code to explain. |
|
This is important functionality, please consider merging. |
Member
Member
|
Would you mind fixing the merge conflicts of this PR? |
Closed
Member
|
Thank you for this PR ❤️ @pubpub-zz has put a lot of effort in bringing similar improvements to PyPDF2. As I believe that we have everything already merged, I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve issue #168