BUG: Append pdf with named destination using numbers for pages#1858
Merged
MartinThoma merged 8 commits intopy-pdf:mainfrom Jun 25, 2023
Merged
BUG: Append pdf with named destination using numbers for pages#1858MartinThoma merged 8 commits intopy-pdf:mainfrom
MartinThoma merged 8 commits intopy-pdf:mainfrom
Conversation
add a new property to ease access to page number on all objects
closes py-pdf#471 the issue was with named destination using numbers instead of indirect object to point pages. This is normally not expected.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
=======================================
Coverage 93.81% 93.82%
=======================================
Files 34 34
Lines 6922 6932 +10
Branches 1365 1367 +2
=======================================
+ Hits 6494 6504 +10
Misses 280 280
Partials 148 148
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
all yours |
Member
|
Nice! Thank you @pubpub-zz 🤗 |
Member
|
It's amazing that you're solving also the very old issues 👏 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #471
closes #1898
the issue was with named destination using numbers instead of indirect object to point pages. This is normally not expected.
For the Reviewer