Codecov Report

Base: 91.92% // Head: 91.92% // No change to project coverage 👍

Coverage data is based on head (7d6cb4f) compared to base (4e276b2).
Patch has no changes to coverable lines.

@@           Coverage Diff           @@
##             main    #1647   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          33       33           
  Lines        6375     6375           
  Branches     1272     1272           
=======================================
  Hits         5860     5860           
  Misses        327      327           
  Partials      188      188           

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paternal
Thanks for you contribution. I would more likely recommend to use .merge_transformed_page() instead of doing the transform before merging. The advantage is that you can reuse the page.
we could keep the merge_page for the watermarking only.
Also maybe you could propose to update the example for underlay watermark using the over=False new option.

@paternal Thanks for you contribution. I would more likely recommend to use .merge_transformed_page() instead of doing the transform before merging.

Unless I misunderstood you, it is already done that way: since most of the examples on this page use merge_page(), I started with a naïve solution using this, that does not work. I then explain why it does not work, and I go on with the right solution using merge_transformed_page().

The advantage is that you can reuse the page. we could keep the merge_page for the watermarking only. Also maybe you could propose to update the example for underlay watermark using the over=False new option.

This page? https://pypdf.readthedocs.io/en/stable/user/add-watermark.html?highlight=watermark
I can update it.

@paternal Thanks for you contribution. I would more likely recommend to use .merge_transformed_page() instead of doing the transform before merging.

Unless I misunderstood you, it is already done that way: since most of the examples on this page use merge_page(), I started with a naïve solution using this, that does not work. I then explain why it does not work, and I go on with the right solution using merge_transformed_page().

I did not read correctly your proposal with the diff mod of github 🤭
I've seen so many people using transformation, that is currently not applying any changes on the annots.

The advantage is that you can reuse the page. we could keep the merge_page for the watermarking only. Also maybe you could propose to update the example for underlay watermark using the over=False new option.

This page? https://pypdf.readthedocs.io/en/stable/user/add-watermark.html?highlight=watermark I can update it.

yes🙂

Done.

English is not my first language: feel free to rephrase everything.

@paternal Thank you 🙏

If you want, I can add you to the contributors page: https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html
Just let me know which name I should use :-) (just Louis? paternal?)

Just let me know which name I should use :-) (just Louis? paternal?)

Louis Paternault https://framagit.org/spalax

Thanks

done :-)