Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: py-pdf/pypdf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.28.1
Choose a base ref
...
head repository: py-pdf/pypdf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.28.2
Choose a head ref
  • 3 commits
  • 5 files changed
  • 2 contributors

Commits on May 23, 2022

  1. BUG: Fix deprecation warning on using PdfMerger (#891) 

    Fixes a deprecation warning being raised when trying to use the PdfMerger class. This regression of #887 is caused by #889 which reversed the changes done to the PyPDF2/merger.py module so that it once again used the deprecated user-facing isString method as opposed to the internal _isString method.

Additionally, this PR fixes the deprecation warning raised by referencing reader.namedDestinations as opposed to reader.named_destinations.

Closes #890
    @MasterOdin
    MasterOdin authored May 23, 2022
    Configuration menu
    Copy the full SHA
    68c9202 View commit details
    Browse the repository at this point in the history

  2. BUG: PendingDeprecationWarning for getContents (#893)

    @MartinThoma
    MartinThoma authored May 23, 2022
    Configuration menu
    Copy the full SHA
    9947c7b View commit details
    Browse the repository at this point in the history

  3. REL: 1.28.2 

    Bug Fixes (BUG):
-  PendingDeprecationWarning for getContents (#893)
-  PendingDeprecationWarning on using PdfMerger (#891)
    @MartinThoma
    MartinThoma committed May 23, 2022
    Configuration menu
    Copy the full SHA
    c68b98d View commit details
    Browse the repository at this point in the history
Loading