Skip to content

BUG: Fix PendingDeprecationWarning on merge/transform PageObject #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinThoma merged 1 commit into from
May 25, 2022
Merged

BUG: Fix PendingDeprecationWarning on merge/transform PageObject #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions PyPDF2/_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,8 +603,8 @@ def _merge_page(
max(corners1[3], upperright[1]),
)

self.mediabox.setLowerLeft(lowerleft)
self.mediabox.setUpperRight(upperright)
self.mediabox.lower_left = lowerleft
self.mediabox.upper_right = upperright

self[NameObject(PG.CONTENTS)] = ContentStream(new_content_array, self.pdf)
self[NameObject(PG.RESOURCES)] = new_resources
Expand Down Expand Up @@ -919,8 +919,8 @@ def add_transformation(
max(corners[3], upperright[1]),
)

self.mediabox.setLowerLeft(lowerleft)
self.mediabox.setUpperRight(upperright)
self.mediabox.lower_left = lowerleft
self.mediabox.upper_right = upperright
self[NameObject(PG.CONTENTS)] = content

def addTransformation(self, ctm: CompressedTransformationMatrix) -> None:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_basic_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_basic_features():

# add page 5 from input1, but crop it to half size:
page5 = reader.pages[0]
page5.mediabox.upperRight = (
page5.mediabox.upper_right = (
page5.mediabox.right / 2,
page5.mediabox.top / 2,
)
Expand Down