Fix "Undefined property: stdClass::$channels"#281
Merged
WillSewell merged 2 commits intopusher:masterfrom Feb 22, 2021
Koozza:fix-undefined-property-channels
Merged
Fix "Undefined property: stdClass::$channels"#281WillSewell merged 2 commits intopusher:masterfrom Koozza:fix-undefined-property-channels
WillSewell merged 2 commits intopusher:masterfrom
Koozza:fix-undefined-property-channels
Conversation
|
I'm not able to replicate this, when using the following code no error is output:
Are you using the php library directly or is this error occurring as part of the Laravel Echo framework? |
Contributor
Author
|
I'm using it directly within laravel, but not as part of Laravel Echo. Example call: The So accoring to the code: And thus making Give a undefined property. (Please note that this only occurs if no "info" is given). |
This was referenced Feb 22, 2021
Closed
WillSewell
approved these changes
Feb 22, 2021
Contributor
WillSewell
left a comment
There was a problem hiding this comment.
Thank you for investigating and fixing this.
Co-authored-by: Will Sewell <me@willsewell.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no
infokey is present in the$paramsarray Pusher will not return the channels property in the request. There is a if statement in place, but it doesn't check if the property actually exists.So by just using the package and using the trigger method will provide you with a exception.