Remove usages of Data.Tuple.Nested. #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data.Tuple.Nested moved to meaning extensible tuples, which implies ending the Tuple in Unit. This added Unit causes an extra space to be added to a tuple-backed CSS rule, like animation. In addition, we aren't using tuple-combinators, which extensible tuples enables.
Contributor
|
Maybe just use do something like this |
4 tasks
Contributor
|
Superceded by #135. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data.Tuple.Nested moved to meaning extensible tuples, which
implies ending the Tuple in Unit. This added Unit causes an extra
space to be added to a tuple-backed CSS rule, like animation.
In addition, we aren't using tuple-combinators, which extensible
tuples enables.
See discussion: #43 (comment)
Note that this patch isn't DRY - I reimplemented tuple4 several times. What's the preferred way to handle that?