Skip to content

Remove run.js #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
f-f merged 7 commits into from
Jan 31, 2022
Merged

Remove run.js #846

f-f merged 7 commits into from
Jan 31, 2022

Conversation

@sigma-andex
Copy link
Contributor

@sigma-andex sigma-andex commented Jan 30, 2022 •
edited
Loading

Description of the change

This removes the creation of a run.js file when running spago run. The file content is now passed as an argument to node. Solves #845 .

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

f-f
f-f reviewed Jan 30, 2022
View reviewed changes
sigma-andex and others added 3 commits January 30, 2022 15:23
@sigma-andex @f-f
Update CHANGELOG.md
1c076c0 
Co-authored-by: Fabrizio Ferrai <fabrizio.ferrai@gmail.com>
@sigma-andex @f-f
Update src/Spago/Build.hs
1909173 
Co-authored-by: Fabrizio Ferrai <fabrizio.ferrai@gmail.com>
@sigma-andex
Fix missing display
740d7e8
f-f
f-f approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@f-f f-f merged commit 1eaa825 into purescript:master Jan 31, 2022
@sigma-andex sigma-andex deleted the remove-runjs branch January 31, 2022 07:30
@sigma-andex
Copy link
Contributor Author

sigma-andex commented Jan 31, 2022

Awesome. thx :-)

@sigma-andex sigma-andex mentioned this pull request Jan 31, 2022
Closed
@f-f f-f mentioned this pull request Jan 31, 2022
Closed
@JordanMartinez JordanMartinez mentioned this pull request Feb 9, 2022
Closed
@JordanMartinez JordanMartinez mentioned this pull request Mar 2, 2022
Closed
4 tasks
@sigma-andex sigma-andex mentioned this pull request Mar 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f-f f-f f-f approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sigma-andex @f-f