Skip to content

Update to v0.15.0 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JordanMartinez merged 10 commits into from
Mar 14, 2022
Merged

Update to v0.15.0 #47

JordanMartinez merged 10 commits into from
Mar 14, 2022

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Mar 14, 2022

Description of the change

Backlinking to purescript/purescript#4244

Migrates FFI to ES modules

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added type: breaking change A change that requires a major version bump. purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 labels Mar 14, 2022
thomashoneyman
thomashoneyman reviewed Mar 14, 2022
View reviewed changes
src/Control/Monad/ST/Internal.js
};
};
}
export { newSTRef as new };
Copy link
Member

@thomashoneyman thomashoneyman Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Does lebab do this by default?

Copy link
Contributor Author

@JordanMartinez JordanMartinez Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was done by @kl0tl. See 5ba6007#diff-9c608e1cbaa7f43f3029de5e7a1eb12e0bbb6a430bfe129fe3c715c82ad266c6R29

@JordanMartinez JordanMartinez merged commit f22bedf into purescript:master Mar 14, 2022
@JordanMartinez JordanMartinez deleted the es-modules-libraries branch March 14, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JordanMartinez @thomashoneyman @kl0tl