Expand docs #6
Merged
Expand docs #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Safe/Coerce.purs
Outdated
| -- | no-op because of newtypes. For example, if you have an `Array (Conj a)` and you | ||
| -- | want an `Array (Disj a)`, you could do `Data.Array.map (runConj >>> Disj)`, but | ||
| -- | want an `Array (Disj a)`, you could do `Data.Array.map (un Conj >>> Disj)`, but | ||
| -- | this performs an unnecessary traversal. `coerce` accomplishes the same |
Contributor
There was a problem hiding this comment.
Would it help to note that the unnecessary traversal in this case is O(n) to help show the contrast more?
Collaborator
Author
There was a problem hiding this comment.
Yes, that sounds good to me
JordanMartinez
approved these changes
Oct 13, 2020
Contributor
JordanMartinez
left a comment
There was a problem hiding this comment.
This is definitely cleaner. LGTM!
Contributor
|
Hm... CI is failing because there isn't a test folder and its running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runConj(which no longer exists)