Skip to content

Conversation

@thomashoneyman
Copy link
Member

This PR migrates profunctor to use GitHub Actions instead of Travis for CI, as tracked for all core libraries in purescript/purescript#3962. It also updates the installation instructions to refer to Spago instead of Bower.

Copy link
Member

@kl0tl kl0tl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know why this builds without warning but there’s a MonadZero instance for Star. Do you prefer to censor user defined warnings in this pull request or in another one, once we figured out why the warning isn’t emitted?

@kl0tl
Copy link
Member

kl0tl commented Dec 6, 2020

The warning is ignored because of the MonadZero constraint in the instance context. I’ve opened purescript/purescript-control#68 to circumvent this, so we should censor user defined warnings in this pull request or CI will fail once the other one is merged.

@thomashoneyman thomashoneyman merged commit 120a764 into master Dec 8, 2020
@thomashoneyman thomashoneyman deleted the github-actions branch December 8, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants