Fix warnings and doc-comments for 0.14 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think the branch got deleted and that's why the PRs were closed |
Contributor
Author
|
Both branches still exist on the respective repositories, that’s how I was able to put this PR together |
JordanMartinez
approved these changes
Oct 1, 2020
Contributor
|
Oh cool, thanks for keeping my commits! |
Contributor
Author
|
Sure 🙂 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #226, except that it's based on the previous PRs #209 and #211 which mysteriously got closed - apparently by me but I don't remember doing that - and GitHub won't let me reopen them either. I'd like to merge this one instead of #226 since it preserves @Thimoteus's authorship as well as the doc-comment update in NaturalTransformation.