Skip to content

Speed up keys by using foldrWithIndex #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JordanMartinez merged 2 commits into from
Apr 22, 2022
Merged

Speed up keys by using foldrWithIndex #62

JordanMartinez merged 2 commits into from
Apr 22, 2022

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Apr 22, 2022 •
edited
Loading

Description of the change

Addresses the comment raised by @xgrommx here: #61 (comment)

Map
===
keys
---------------
Map2a0bff.keys: big map (1000000)
mean   = 2.64 s
stddev = 199.37 ms
min    = 2.39 s
max    = 2.96 s
M.keys: big map (1000000)
mean   = 218.74 ms
stddev = 34.92 ms
min    = 194.87 ms
max    = 301.29 ms

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

thomashoneyman
thomashoneyman reviewed Apr 22, 2022
View reviewed changes
bench/Bench/Data/Map.purs Outdated

log "keys"
log "---------------"
benchValues
Copy link
Member

@thomashoneyman thomashoneyman Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be benchKeys

Copy link
Contributor Author

@JordanMartinez JordanMartinez Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. I'll fix and repost benchmarks.

Copy link
Contributor Author

@JordanMartinez JordanMartinez Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening comment now has updated benchmarks.

@JordanMartinez JordanMartinez merged commit 6221be7 into purescript:master Apr 22, 2022
@JordanMartinez JordanMartinez deleted the fix-keys branch April 22, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez @thomashoneyman