Keep number conversion implementation detail internal #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Nov 13, 2020
src/Random/LCG.purs
Outdated
|
|
||
| -- | Perturb a seed value | ||
| lcgPerturb :: Number -> Seed -> Seed | ||
| -- | Note that `Int` operations are truncated to 32-bits, so we convert to |
Contributor
There was a problem hiding this comment.
This is an implementation detail, and so it probably shouldn't be in a doc-comment.
Contributor
|
I suspect this function is used for Coarbitrary instances, so changing this would likely require changes downstream, although I suspect not too many. It looks to me like we probably ought to prevent people from passing things which aren't 32-bit integers: if you pass a fractional number I suspect the |
hdgarrood
reviewed
Nov 13, 2020
Co-authored-by: Harry Garrood <harry@garrood.me>
hdgarrood
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this code is more straightforward with all the
Numberconversions isolated as an implementation detail.This is technically a version bump. Not sure if any other libraries use
lcgPerturb.Based on #6