Skip to content

Update to v0.14.0-rc3 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JordanMartinez merged 4 commits into from
Nov 5, 2020
Merged

Update to v0.14.0-rc3 #24

JordanMartinez merged 4 commits into from
Nov 5, 2020

Conversation

@paluh
Copy link
Contributor

@paluh paluh commented Oct 15, 2020

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Oct 23, 2020

CI failed because npm run -s test failed. However, it seems that CI failed because there isn't a test script in packages.json. Do we add a test script that calls pulp test? Or something else?

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Oct 24, 2020

@paluh Please update the package.json file to include the test script. CI will fail until we add this:

  "scripts": {
    "test": "pulp test"
  },

JordanMartinez
JordanMartinez approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI builds now.

@JordanMartinez JordanMartinez mentioned this pull request Oct 29, 2020
Closed
57 tasks
hdgarrood
hdgarrood reviewed Nov 4, 2020
View reviewed changes
src/Data/Functor/Compose.purs Outdated
import Data.Tuple (Tuple, curry)

-- | `Compose f g` is the composition of the two functors `f` and `g`.
newtype Compose ∷ ∀ k1 k2. (k2 → Type) → (k1 → k2) → k1 → Type
Copy link
Contributor

@hdgarrood hdgarrood Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use ascii syntax here please?

@hdgarrood
Copy link
Contributor

hdgarrood commented Nov 4, 2020

I’m happy to merge this once we’re using ascii syntax everywhere.

@paluh
Copy link
Contributor Author

paluh commented Nov 4, 2020 •
edited
Loading

@hdgarrood Yeah, sure - once again sorry for this mess. I'm going to review all my 0.14 related PR's soon to ensure that I didn't make this mistake anywhere else.

@hdgarrood
Copy link
Contributor

hdgarrood commented Nov 4, 2020

No worries at all ❤️ thanks again for your PRs!

@paluh
Copy link
Contributor Author

paluh commented Nov 4, 2020

grep claims that I don't have any more unicode syntax in this or any other 0.14 PRs. I hope that is true :-)

@JordanMartinez JordanMartinez merged commit 02708f0 into purescript:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

+2 more reviewers

@hdgarrood hdgarrood hdgarrood left review comments

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paluh @JordanMartinez @hdgarrood @thomashoneyman