Adds semigroup and monoid instances for Cofree #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
approved these changes
Sep 8, 2021
Member
thomashoneyman
left a comment
There was a problem hiding this comment.
This looks fine to me, but I'd like to leave this open for a little while so folks more familiar with Cofree (which I've rarely used) can weigh in. If no one else does, then I'm happy to merge in a week or so.
garyb
reviewed
Sep 8, 2021
Co-authored-by: Gary Burgess <gary.burgess@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The purpose of the pull request is to decrease the burden on library writers of creating newtypes for
Cofreewhen they want semigroup and monoid instances. For example, in https://github.com/mikesol/purescript-wags-lib/blob/main/src/WAGS/Lib/Rate.purs and many other files in that project, custom Semigroup and Monoid instances are created using this pattern, which leads to lots of code duplication.From my testing, it seems that these follow the
SemigroupandMonoidlaws.Checklist: